search

maxbeizer / ueberauth_heroku

Elixir oauth strategy using Heroku
https://hex.pm/packages/ueberauth_heroku
MIT License
3 stars 1 forks source link

Bump up versions used and remove Poison dependency #4

Closed filipecabaco closed 3 years ago

filipecabaco commented 4 years ago

Removed Poison dependency by bumping up oauth2 dependency and adding setting the JSON client of OAuth using Ueberauth's json_library() function.

Refer to https://github.com/ueberauth/ueberauth_facebook/pull/48

filipecabaco commented 4 years ago

Unsure about it but this could be a breaking change. It might need a bump in minor

maxbeizer commented 4 years ago

Thanks for the PR @filipecabaco ! I'll be taking a look later today

filipecabaco commented 3 years ago

Hi 👋 wondering if this could be merged 🙏

maxbeizer commented 3 years ago

@filipecabaco oh my. I'm really sorry this slipped my mind 🙇

maxbeizer commented 3 years ago

I'll try to cut a new release ASAP

filipecabaco commented 3 years ago

Oh no worries! Didn't want to rush you just wanted to have an idea

Nonetheless, thank you for the help 🙏

maxbeizer commented 3 years ago

@filipecabaco https://hexdocs.pm/ueberauth_heroku/0.3.0/api-reference.html is out. Thanks for your patience and sorry again about the delay

filipecabaco commented 3 years ago

Don't be sorry, I am for rushing you. Thank you for the availability, time, and code 🙏