search

maxbrunsfeld / atom-nrepl

An nrepl client for clojure development in atom
Other
31 stars 8 forks source link

Fix deprecated selector #5

Closed koozz closed 9 years ago

koozz commented 9 years ago

Atom has a built-in "Deprecation cop" which hints about a new selector to use instead of this deprecated one.

Would need a new release though.

maxbrunsfeld commented 9 years ago

Thanks for noticing this. Did you test the changed version though? It's actually supposed to be atom-workspace; no dot at the beginning, as it's a tag-name, not a class anymore.

koozz commented 9 years ago

When running Atom, you can quickly fix it locally. With the class ".atom-workspace" it has nothing to complain. Classes in CSS always start with a dot. So I guess it needs to be prefixed with a dot.

Only know that the warning is gone now. :)

maxbrunsfeld commented 9 years ago

It is not a class. atom-workspace is the name of a custom HTML tag, like div, span, etc. 

document.querySelectorAll(".atom-workspace").length // => 0
document.querySelectorAll("atom-workspace").length // => 1

I would think that with your change, the keybinding would no longer work, because the selector doesn't match anything.