search

maxbucknell / magento-amdjs

JavaScript module loader using AMD
MIT License
6 stars 2 forks source link

Make the minifier work better #13

Open maxbucknell opened 10 years ago

maxbucknell commented 10 years ago

Remove the variable, and pass things via stdin, or just find the raw module paths and do it that way.

maxbucknell commented 10 years ago

Currently, I write the concatenated scripts to a temporary file. I could cat this out and pipe it into a custom minifier command, but, that's using a temporary file. That's the only way I see of getting that to work. Even then, that's kinda saying screw windows, because pipes.

I can pass the files through the minifier, that definitely works. But the variable is still there. I think that's the best thing to do going forwards.