search

maxcell / prince.dev

MIT License
3 stars 4 forks source link

Add a search capability #35

Open maxcell opened 4 years ago

maxcell commented 4 years ago

Initially this will just be a search box implementation. But potentially will try to extend this to an omnibox kinda thing too potentially

maxcell commented 4 years ago

Primarily added through a6f450953. I don't want to close this yet though because we should do a second pass and make sure it is accessible:

  1. Make sure the buttons have an aria-label
  2. Investigate how to indicate that the buttons are for refinement

And in addition, a second pass to encapsulate more behavior will be ideal. The search box isn't quite clear and it should read a bit better as far as a component.