Use address argument instead of full-connection if address is defined

maxcnunes / waitforit

Wait until an address become available.

MIT License

173 stars 26 forks source link

Use address argument instead of full-connection if address is defined #13

Closed maxcnunes closed 7 years ago

maxcnunes commented 7 years ago

Since the beginning I wasn't glad with the full-connection argument name. I believe just address has the same meaning and it is simpler. My intention isn't to deprecate full-connection to not cause a breaking change for anyone. But address will be the default argument for the address information and full-connection will only be used if address isn't defined.

coveralls commented 7 years ago

Coverage increased (+0.6%) to 57.386% when pulling 1ac43da056a1d6b50a87af93722cc0c206f31571 on address into db7de8a073339ecd1143ffa27913818ecf1825f2 on master.

coveralls commented 7 years ago

Coverage increased (+0.6%) to 57.386% when pulling d64eb866d3e99a66056b4885ce387c0cfe1b444f on address into db7de8a073339ecd1143ffa27913818ecf1825f2 on master.

coveralls commented 7 years ago

Coverage increased (+0.6%) to 57.386% when pulling ba2779bb69164d8dcff423e8e40069c83bb42717 on address into db7de8a073339ecd1143ffa27913818ecf1825f2 on master.