search

maxcnunes / waitforit

Wait until an address become available.
MIT License
173 stars 26 forks source link

Improve headers parsing - fix #24 #25

Closed nsteinmetz closed 6 years ago

nsteinmetz commented 6 years ago

Headers seems to be on the format <key>: <value>

Fix will split on the pattern : and then would remove any space on the left side of the 2nd element.

Ex:

Authorization: Basic MyEncodedCredentials

Split will generate : Authrorization & Basic MyEncodedCredentials Trimleft will do nothing more in this case

Authorization:     Basic MyEncodedCredentials

Split will generate : Authrorization & Basic MyEncodedCredentials Trimleft will generate: Basic MyEncodedCredentials

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 60

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 110
Relevant Lines: 224
💛 - Coveralls
nsteinmetz commented 6 years ago

Here you are - same output for the 2 cases.

maxcnunes commented 6 years ago

Thanks!!

nsteinmetz commented 6 years ago

Happy to contribute :)

nsteinmetz commented 6 years ago

@maxcnunes do you plan to make a 2.4.1 release ? To know if I use master or wait for the 2.4.1 release