Unset client cookies on session destroy

maxcountryman / axum-sessions

🥠 Cookie-based sessions for Axum via async-session.

MIT License

74 stars 18 forks source link

Unset client cookies on session destroy #4

Closed Ptrskay3 closed 2 years ago

Ptrskay3 commented 2 years ago

I think it's reasonable to unset cookies at client side whenever the session is destroyed. (At least actix-sessions does this.)

Also, in my opinion it's a much nicer experience to avoid panics, because that causes the response to hang and never arrive. Instead, on storage failure we should send back a 500 INTERNAL_SERVER_ERROR. Also added tracing errors to appropriate places.

Let me know what do you think about these changes.

maxcountryman commented 2 years ago

This looks great! Thank you for putting it together. I have one question about the branch you mentioned but I'm happy to merge this as-is.

maxcountryman commented 2 years ago

Version 0.2.0 is now available and includes these changes.