maxcountryman
commented
6 months ago So far, I'm not able to reproduce this. I've tried to modify the sqlite example to use RedisStore and it seems to work as expected. Here's a diff:
diff --git a/examples/sqlite/Cargo.toml b/examples/sqlite/Cargo.toml
index ae87964..64bb358 100644
--- a/examples/sqlite/Cargo.toml
+++ b/examples/sqlite/Cargo.toml
@@ -20,8 +20,8 @@ time = "0.3.30"
tokio = { version = "1.34.0", features = ["full"] }
tower = "0.4.13"
tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
-tower-sessions = { version = "0.12.0", default-features = false, features = [
+tower-sessions = { version = "0.12.1", default-features = false, features = [
"signed",
] }
-tower-sessions-sqlx-store = { version = "0.12.0", features = ["sqlite"] }
+tower-sessions-redis-store = { version = "0.12.0" }
thiserror = "1.0.56"
diff --git a/examples/sqlite/src/web/app.rs b/examples/sqlite/src/web/app.rs
index 70e72ff..cf8aebc 100644
--- a/examples/sqlite/src/web/app.rs
+++ b/examples/sqlite/src/web/app.rs
@@ -1,14 +1,16 @@
use axum_login::{
login_required,
- tower_sessions::{ExpiredDeletion, Expiry, SessionManagerLayer},
+ tower_sessions::{Expiry, SessionManagerLayer},
AuthManagerLayerBuilder,
};
use axum_messages::MessagesManagerLayer;
use sqlx::SqlitePool;
use time::Duration;
-use tokio::{signal, task::AbortHandle};
use tower_sessions::cookie::Key;
-use tower_sessions_sqlx_store::SqliteStore;
+use tower_sessions_redis_store::{
+ fred::{clients::RedisPool, interfaces::ClientLike, types::RedisConfig},
+ RedisStore,
+};
use crate::{
users::Backend,
@@ -32,14 +34,12 @@ impl App {
//
// This uses `tower-sessions` to establish a layer that will provide the session
// as a request extension.
- let session_store = SqliteStore::new(self.db.clone());
- session_store.migrate().await?;
+ let pool = RedisPool::new(RedisConfig::default(), None, None, None, 6)?;
+
+ let redis_conn = pool.connect();
+ pool.wait_for_connect().await?;
- let deletion_task = tokio::task::spawn(
- session_store
- .clone()
- .continuously_delete_expired(tokio::time::Duration::from_secs(60)),
- );
+ let session_store = RedisStore::new(pool);
// Generate a cryptographic key to sign the session cookie.
let key = Key::generate();
@@ -65,36 +65,10 @@ impl App {
let listener = tokio::net::TcpListener::bind("0.0.0.0:3000").await.unwrap();
// Ensure we use a shutdown signal to abort the deletion task.
- axum::serve(listener, app.into_make_service())
- .with_graceful_shutdown(shutdown_signal(deletion_task.abort_handle()))
- .await?;
+ axum::serve(listener, app.into_make_service()).await?;
- deletion_task.await??;
+ redis_conn.await??;
Ok(())
}
}
-
-async fn shutdown_signal(deletion_task_abort_handle: AbortHandle) {
- let ctrl_c = async {
- signal::ctrl_c()
- .await
- .expect("failed to install Ctrl+C handler");
- };
-
- #[cfg(unix)]
- let terminate = async {
- signal::unix::signal(signal::unix::SignalKind::terminate())
- .expect("failed to install signal handler")
- .recv()
- .await;
- };
-
- #[cfg(not(unix))]
- let terminate = std::future::pending::<()>();
-
- tokio::select! {
- _ = ctrl_c => { deletion_task_abort_handle.abort() },
- _ = terminate => { deletion_task_abort_handle.abort() },
- }
-}
Elizafox
Bug Report
Version
0.15.0
Platform
Darwin ember.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:17:35 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8112 arm64FreeBSD river.z6a.info 13.2-RELEASE-p1 FreeBSD 13.2-RELEASE-p1 GENERIC amd64Crates
tower_sessions_redis_store(version 0.12.0)tower_sessions(version 0.12.1)Description
Attempting to call
AuthSession.login()with thetower_sessions_redis_storebackend fails with:This does not happen with at least the Moka backend.
This is a regression, as it worked with prior versions.