Closed maxcurrent420 closed 8 months ago
b5d30278a6
)[!TIP] I can email you next time I complete a pull request if you set up your email here!
Here are the GitHub Actions logs prior to making any changes:
a9acf57
Checking utils/dialogues.js for syntax errors... β utils/dialogues.js has no syntax errors!
1/1 βChecking utils/dialogues.js for syntax errors... β utils/dialogues.js has no syntax errors!
Sandbox passed on the latest main
, so sandbox checks will be enabled for this issue.
I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.
utils/dialogues.js
β https://github.com/maxcurrent420/BeastBreeder/commit/7a34295dce5817bcab3ff1d22a70991c91a44cd3 Edit
Modify utils/dialogues.js with contents:
β’ Add a new key-value pair to the dialogues object for each new NPC. The key should be the name of the NPC and the value should be an array of strings representing the dialogues for that NPC.
β’ For the "Village Elder", add dialogues that reflect the elder's role in providing quests and guidance to the player.
β’ For the "Seer", add dialogues that suggest the seer's ability to predict the future or provide cryptic advice.
β’ For the "Blacksmith", the dialogues are already present in the existing code. No changes are needed for this NPC.
β’ For the "Shopkeeper", the dialogues are already present in the existing code. No changes are needed for this NPC.
β’ For the "Bugfight Club Bouncer", add dialogues that reflect the bouncer's role in controlling access to the bugfight club and interacting with the player.
--- +++ @@ -13,5 +13,13 @@ "Need some new gear? You've come to the right place.", "This is one of my finest creations. It will serve you well.", "Safe travels, adventurer. May your blade always be sharp." + ], + "Seer": [ + "I foresee a challenge that only you can overcome.", + "The strings of fate are tangled. Your path is a complex one." + ], + "Bugfight Club Bouncer": [ + "You're not on the list. No entry.", + "You think you can handle the fights? Prove it." ] };
utils/dialogues.js
β Edit
Check utils/dialogues.js with contents:
Ran GitHub Actions for 7a34295dce5817bcab3ff1d22a70991c91a44cd3:
I have finished reviewing the code for completeness. I did not find errors for sweep/npcs
.
π‘ To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord
Details
I need you to add NPCs to the NPCs file. Include a village elder, a seer, a blacksmith, and a shopkeeper, and a "bugfight club" bouncer.
Checklist
- [X] Modify `utils/dialogues.js` β https://github.com/maxcurrent420/BeastBreeder/commit/7a34295dce5817bcab3ff1d22a70991c91a44cd3 [Edit](https://github.com/maxcurrent420/BeastBreeder/edit/sweep/npcs/utils/dialogues.js) - [X] Running GitHub Actions for `utils/dialogues.js` β [Edit](https://github.com/maxcurrent420/BeastBreeder/edit/sweep/npcs/utils/dialogues.js)