maxcurzi / tplay

A terminal ASCII media player. View images, gifs, videos, webcam, YouTube, etc.. directly in the terminal as ASCII art.
MIT License
246 stars 16 forks source link

Add shields for aur and make table of contents foldable #17

Closed neon-mmd closed 1 year ago

neon-mmd commented 1 year ago

I have added two shields to show the status of aur package and for the maintainance status and also made table of contents foldable, this will make the readme feel less lengthy for the reader.

neon-mmd commented 1 year ago

Ok sure no problem, I will take it out :smile: .

neon-mmd commented 1 year ago

Ok as per your request I removed it :smile: .

maxcurzi commented 1 year ago

I meant remove all new badges except the one that points to the AUR package (the one with the version number) ☺️

neon-mmd commented 1 year ago

I meant remove all new badges except the one that points to the AUR package (the one with the version number) relaxed

My bad, I took it in the other way. just spare me a few minutes and I will come back to you.

One more thing before I make the change, I think the maintainance status shield would be necessary because this will show the reader that yes your project is well maintained and active and it is not a dead project :smile: . If you wish I can make the badges and the project title look something similar to this one:

image

or like this one:

image

maxcurzi commented 1 year ago

I meant remove all new badges except the one that points to the AUR package (the one with the version number) relaxed

My bad, I took it in the other way. just spare me a few minutes and I will come back to you.

One more thing before I make the change, I think the maintainance status shield would be necessary because this will show the reader that yes your project is well maintained and active and it is not a dead project smile . If you wish I can make the badges and the project title look something similar to this one:

image

or like this one:

image

I understand but I still don't like it.

It doesn't take much to see if a project is maintained or not, in fact I think it's a better practice to understand what's the maintenance status of a project based on commits, PR's etc... and form your own opinion/judgement.

neon-mmd commented 1 year ago

Agreed :+1:, Ok so in few minutes I am going to make the change.

neon-mmd commented 1 year ago

Ok done :+1: , you review the change again :smile: .

neon-mmd commented 1 year ago

Also a few areas to improve in your project:

neon-mmd commented 1 year ago

Ok finally I realized my mistake :smile: that I had mistakenly added a maintanance status badge with html but I have now resolved the error you can review the change again.

Note: I closed and reopened the issue because I thought what's wrong why is it not updating but finally realized my mistake as mentioned above and reopened this issue :).