maxcurzi / tplay

A terminal ASCII media player. View images, gifs, videos, webcam, YouTube, etc.. directly in the terminal as ASCII art.
MIT License
246 stars 16 forks source link

remove Cargo.lock #31

Closed Demine0 closed 11 months ago

Demine0 commented 11 months ago

Hi, I want to create nixpkgs for tplay, please update the dependencies in README.md and also I would be very grateful if you will not publish Cargo.lock

maxcurzi commented 11 months ago

Please see this: https://github.com/maxcurzi/tplay/issues/7 I'm not familiar with nixpkgs but it sounds like i'm getting conflicting information ;)

Demine0 commented 11 months ago

Please see this: https://github.com/maxcurzi/tplay/issues/7

I'm not familiar with nixpkgs but it sounds like i'm getting conflicting information ;)

I had problems with this, I had to do cargoPatch for 2 thousand lines.

https://github.com/NixOS/nixpkgs/pull/266041

maxcurzi commented 11 months ago

Let's ping @colemickens in case he made progress on nixpkgs packaging this crate!

If removing cargo.lock is the way forward I'll merge this, but I don't want to impede any work in progress that require cargo.lock

3JlOy-PYCCKUi commented 11 months ago

Cargo.lock actually must be in the repository. Its presence is not the cause of packaging problems in nixpkgs, the problem is that in this commit you updated the program version in Cargo.toml, but did not update Cargo.lock. But no action on your side is required, this can be fixed with a one line patch

colemickens commented 11 months ago

I have a draft open on nixpkgs. From looking, I don't think we package anything that uses rust and opencv and I still couldn't get it to work. I've sort of given up, it's beyond my nix skils

maxcurzi commented 11 months ago

It's a tricky thing indeed, perhaps @Demine0 will have better luck in making OpenCV play nicely with nixpkgs

Demine0 commented 11 months ago

It's a tricky thing indeed, perhaps @Demine0 will have better luck in making OpenCV play nicely with nixpkgs

Package work, now i'm trying to go into nixpkgs