search

maxcurzi / tplay

A terminal ASCII media player. View images, gifs, videos, webcam, YouTube, etc.. directly in the terminal as ASCII art.
MIT License
208 stars 13 forks source link

update ffmpeg version #35

Open MoonDusk1996 opened 6 months ago

MoonDusk1996 commented 6 months ago

I was facing difficulties when building this because of the ffmpeg version, in the process I realized that version 6.1 was what worked correctly for me, apparently there is no problem

maxcurzi commented 6 months ago

I'll check it out. The Readme should not be changed because the FFMPEG (ffmpeg library) version number is supposed to be different from ffmpeg-next (cargo crate) as they are two different things. Can you check what version of ffmpeg do you have installed?

$ ffmpeg -version

for example:

ffmpeg version 4.4.2-0ubuntu0.22.04.1 Copyright (c) 2000-2021 the FFmpeg developers
built with gcc 11 (Ubuntu 11.2.0-19ubuntu1)
MoonDusk1996 commented 6 months ago

In fact, I didn't know they were different things. This is my return:

ffmpeg version n6.1.1 Copyright (c) 2000-2023 the FFmpeg developers built with gcc 13.2.1 (GCC) 20230801

MarelPup commented 5 months ago

Building this fork on arch with rust works for me

max-curzi commented 5 months ago

let's put a pin on it for the time being, obviously once we bump up the ffmpeg-next version the requirement for ffmpeg changes, and I want to make sure that the main ffmpeg library v6 has time to "settle" and be available everywhere before updating this system-wide library requirement

maxcurzi commented 3 months ago

I'd be interested to know if people managed to build and run tplay after updating ffmpeg to version 6... The crate that this project uses, ffmpeg-next, still doesn't support ffmpeg v6 ( I just tried)!

Guruk13 commented 1 week ago

(i'm Marelpup) the moondusk branch uses ffmpeg 6 and it seems to work fine

maxcurzi commented 1 week ago

Sounds good, I'll try setting it up and update it once I have a bit of downtime!