search

maxcurzi / tplay

A terminal ASCII media player. View images, gifs, videos, webcam, YouTube, etc.. directly in the terminal as ASCII art.
MIT License
246 stars 16 forks source link

updating installation instructions and adding subsections #6

Closed neon-mmd closed 1 year ago

neon-mmd commented 1 year ago

I updated the installation instructions in the README and under For Users section added several subsections for Arch Linux, Other Distros and Install using Cargo and also added your package to the aur and now it can be easily installed with this command:

paru -S tplay-git

Also you can view the package here.

Also one more suggestion, my bad, I forgot to put it in the issues but also write a workflow file this will allow you for automated testing for an example on how to write it. you can take a look at my project's workflow located here.

maxcurzi commented 1 year ago

Thanks for doing this!

Currently, this won't work out of the box, as you noticed in #4 , due to #3 . If I call paru -S tplay-git I get this "recipe" paru -S tplay-git :: Resolving dependencies... :: Calculating conflicts... :: Calculating inner conflicts...

Repo (8) yt-dlp-2023.03.04-1 onetbb-2021.8.0-2 cblas-3.11.0-2
opencv-4.7.0-7 mujs-1.3.3-1 rubberband-3.2.1-1 uchardet-0.0.8-1
mpv-1:0.35.1-4 Aur (1) tplay-git-0.3.1.r104.7636250-1

As you can see, it uses mpv 0.35, which is incompatible with the libmpv-rs crate used in the dependencies.

Unfortunately, the current solution described in #3 is a workaround based on a temporary crate.

I don't think it's possible to select a crate depending on the external dependency (mpv).

It should be solvable with feature flags/build scripts, I'll create a branch to check this out: mpv-select

maxcurzi commented 1 year ago

let's hold off this pull request until the crate can reliably be installed and run (with working audio). Removing the external dependency to mpv would be nice