Open kaleocheng opened 3 years ago
I think this was implemented when includes/excludes with regular expressions were not possible yet. Back then this implementation made sense, because you would either include certain paths or exclude them.
Could you create a pull request for this? If you do, please make sure to add some additional tests and update documentation accordingly.
Probably makes sense to put this into a new major version of the package then, as it is a breaking change.
I'm kind of busy recently but sure, I can create a PR later. 😄
the current strategy ignores
exclude
ifinclude
exists: https://github.com/maxdome/swagger-combine/blob/master/src/SwaggerCombine.js#L87-L99It may be confusing if someone has the configuration like this: (include all paths under
/api/products
excpet for/api/products/{id}/recommendation
)To me it makes more sense to use
instead of
if include else if exclude