search

maxeckel / livewire-editorjs

This Package aims for an easy integration of Editor.JS with Laravel Livewire
MIT License
150 stars 22 forks source link

Fix S3 private fetch and add prefix #20

Open afiqiqmal opened 3 years ago

afiqiqmal commented 3 years ago
maxeckel commented 3 years ago

Hey @afiqiqmal, thank you for the PR, that's really welcome!

I'm with you adding the prefix, but I'm not so sure about the private files. The Problem is, that the temporary url gets saved into the block and when it timed out, that block is basically useless and won't be able to display the upload.

afiqiqmal commented 3 years ago

hmm.. For what i'm understand, if using S3, by default, the visibility of the storage is private. Basically on my case, i want to use private files in cloud. The problem is where when retrieving the private files without temporaryUrl cause a problem which S3 blocked public access.

Basically it is just an idea for my case problem. You may drop this PR if this PR is not suitable.

maxeckel commented 3 years ago

Hey @afiqiqmal,

I think you have a solid point here, I'm just concerned about the images being not available anymore after the temporary url is expired. I think in most cases, when the files are private and not accessible through e.g. CloudFront CDN, people use a dedicated route which will "stream" the files from S3 through your application to your visitor. I've seen this pattern used in cases, where the uploaded files should only be accessible for e.g. authenticated users.

I'm thinking about a more "general" approach, as people might not only use S3. For example, by default files are seen as public (to not break existing functionality), but in cases where they are private we could allow for a customization in how the URL for the image should be generated. Maybe something like in spaties medialibrary (https://spatie.be/docs/laravel-medialibrary/v9/advanced-usage/generating-custom-urls). Even though they don't need to worry about the temp url issue, as the url is not persisted (as far as I know).

What do you think about it?