issues
search
maxempoint
/
AR_GBX
Python Framework for interacting with the Action Replay GBX
GNU General Public License v3.0
0
stars
1
forks
source link
General refactor and code improvements
#18
Closed
philippfriese
closed
2 years ago
philippfriese
commented
2 years ago
This PR:
adds first round of type hints throughout the project (partially resolved #13)
adds several changes from raw file handlers to context managed file objects
normalises code comments to adhere to PEP 8
changes potentially static methods to "real" static methods using
@staticmethod
this more strongly expresses the intent that the static method does not modify parent class members
improves exception messages by adding exception strings
adds several TODO comments to places where
a
match
statement could be used one Python >=3.10 is used
parameters are not used
signatures of base classes are not adhered by
This PR:
@staticmethod
match
statement could be used one Python >=3.10 is used