Fix SPM Usage in Xcode 12.5+

rogerluan commented 3 years ago

Description

On Xcode 12.5, apparently the umbrella header generation logic changed, so this stopped working on my project because my project couldn't find MXScrollView anymore, when importing this lib using SPM. The problem was that the generated umbrella header didn't contain references to all the public headers. This PR aims to fix that.

Motivation and Context

How Has This Been Tested?

It compiles on my project now 😄

Before:

import MXParallaxHeader
…
let scrollView = MXScrollView // Couldn't find reference to MXScrollView

Now, the same code above compiles just fine.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation. - Nope
[ ] I have updated the documentation accordingly. - There's no need to update anything

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rogerluan commented 2 years ago

This is a PR, it's not stale 😢

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rogerluan commented 2 years ago

Still valid

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rogerluan commented 2 years ago

Still valid.

rogerluan commented 2 years ago

@maxep could this PR be reviewed any time? 🙇

rogerluan commented 2 years ago

@maxep hi!👋 feel free to add me as a contributor! Happy to move things forward :) Just make sure I have enough permissions to publish releases (and maybe pods?), so I don't have to bother you again 😄 cheers!

maxep commented 2 years ago

@rogerluan, super nice, thank you!

So I've added you as a collaborator on this project. I've tried to add your email (from your GH profile) to cocoapods, but it seems that you are not yet registered. Could you please register? 👉 https://guides.cocoapods.org/making/getting-setup-with-trunk.html#getting-started

Thanks again!

rogerluan commented 2 years ago

I'll do that tomorrow! 🤗

rogerluan commented 2 years ago

Done @maxep ! :) Same email as my GH profile

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

maxep / MXParallaxHeader