search

maxeth / react-type-animation

A React typewriter animation based on typical with extended functionality and customization.
https://react-type-animation.netlify.app/
MIT License
391 stars 24 forks source link

Upgrade package.json and package-lock.json to support React version 17.x.x or higher #24

Closed Nabilliban14 closed 1 year ago

Nabilliban14 commented 1 year ago

I noticed that this package currently has semantic versioning set to ^16.4.1 for react and react-dom. Are there any plans to upgrade this to semantic versioning using 17.x.x anytime soon? The reason I ask is because by not having this, any react project that does uses ^17.0.0 will throw an error when trying to install this package, and it'd be nice to install this without having to use the --force command or legacy peer dependencies.

maxeth commented 1 year ago

That's just the version used internally, the peer dependencies are >= 15.0.0". in package.json:

  "peerDependencies": {
    "prop-types": "^15.5.4",
    "react": ">= 15.0.0",
    "react-dom": ">= 15.0.0"
  },

Did it throw an error for you?

Nabilliban14 commented 1 year ago

Oh gotcha, I'm not sure what entirely happened on my end then. I tried finding the associated error log but it got lost in my terminal. I'll close this out then, thanks again!