maxeth / react-type-animation

A React typewriter animation based on typical with extended functionality and customization.
https://react-type-animation.netlify.app/
MIT License
427 stars 24 forks source link

ESLint Parser Changes & Elaborated Types #30

Closed andrewpeters9 closed 1 year ago

andrewpeters9 commented 1 year ago
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-type-animation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 4:18pm
netlify[bot] commented 1 year ago

Deploy Preview for react-type-animation canceled.

Name Link
Latest commit 2e0b8bafeda86b8de3cb60b43f12936ae1239aa4
Latest deploy log https://app.netlify.com/sites/react-type-animation/deploys/6499ba342633ad00086382e6
netlify[bot] commented 1 year ago

Deploy Preview for voluble-paletas-a3dba8 canceled.

Name Link
Latest commit 2e0b8bafeda86b8de3cb60b43f12936ae1239aa4
Latest deploy log https://app.netlify.com/sites/voluble-paletas-a3dba8/deploys/6499ba346228e40008f05295
maxeth commented 1 year ago

Hey, I appreciate all the work and improvements.

I noticed that you added the splitter functionality and removed it later on in https://github.com/maxeth/react-type-animation/pull/30/commits/befeae4c7c9bef6946486f18f6e4838f4b9779e7. Any background info on that? 😄 I tested the current state of your pr and the splitting bug with emojis is still present.

andrewpeters9 commented 1 year ago

Hey @maxeth

I removed those changes in order to make a separate PR for them - with this PR I was just intending to add some stricter typings, but let me know if you want them grouped together in the same one.

maxeth commented 1 year ago

I removed those changes in order to make a separate PR for them

okay