maxfilatov / phpuaca

PHPUnit Autocomplete Assistant (PhpStorm plugin)
50 stars 24 forks source link

Contract violation (index access/global resolve) on com.phpuaca.completion.ProphecyTypeProvider.getType #27

Open neuro159 opened 8 years ago

neuro159 commented 8 years ago

We gonna ban the plugin in next build if following is not fixed YOU CANT CALL GLOBL RESOLVE OR ACCESS INDEXES YOURSELF from PhpTypeProvider.getType!!! Please contact me ASAP if you need an assistance.

com.intellij.util.indexing.IndexAccessValidator.checkAccessingIndexDuringOtherIndexProcessing .... at com.jetbrains.php.lang.psi.elements.impl.VariableImpl.resolve(VariableImpl.java:352) at com.phpuaca.completion.ProphecyTypeProvider.getTypeForVariable(ProphecyTypeProvider.java:177) at com.phpuaca.completion.ProphecyTypeProvider.getType(ProphecyTypeProvider.java:56) ....

at com.phpuaca.util.PhpMethodResolver.resolveByMethodReference(PhpMethodResolver.java:15)
at com.phpuaca.completion.PHPUnitTypeProvider.getType(PHPUnitTypeProvider.java:54)
maxfilatov commented 8 years ago

Hi @neuro159

Type providers has been temporary removed from plugin, so problem should be "solved". I'll reimplement it a little bit later without accessing to indexes. Your previous message I understood incorrect like "use dumb service checks and keep calm", sorry :(

scflode commented 8 years ago

@maxfilatov are you still planing on implementing type providers again? It is super useful. Anything one can with help on this?

amakhrov commented 8 years ago

@maxfilatov any news on that?

Haehnchen commented 7 years ago

reimplemented in fork https://github.com/Haehnchen/idea-php-phpunit-plugin