♻️ Create is_null function and implement where pd.isnull is used

maxfordham / ipyautoui

create ipywidgets user input form pydantic model or jsonschema

https://maxfordham.github.io/ipyautoui/

38 stars 5 forks source link

Closed ollyhensby closed 2 months ago

ollyhensby commented 2 months ago

Implementing use of pd.isnull where applicable.

Before we were just checking for None, however, pandas data frame returns nan and therefore was not being captured by the if statement correctly.

The issue was caused by this commit and will be reverted in this PR.

To finally resolve this issue, an is_null function has been created and used in place of pd.isnull.

jgunstone commented 2 months ago

great - looks good to me