search

maxgalbu / xbmc.plugin.video.nba

Kodi plugin to watch NBA games with nba league pass
GNU General Public License v3.0
50 stars 43 forks source link

play mpd #78

Closed mkorganashvili closed 6 years ago

mkorganashvili commented 6 years ago

+Changed user agent to Android (ios gets m3u8 adaptive streaming and it is not supported by kodi) +Inclueded script.module.inputstreamhelper to make it easy to install inputstream/widevine libraries. +Made some changes in favitems to play live games.

Tested on Kodi 18 Windows (works fine) and Kodi 17.6 LibreELEC (plays well, elapsed time is always 0)

ivankokan commented 6 years ago

Do you maybe know what are the differences between inputstream.adaptive and inputstreamhelper you used? Have you tried with inputstream.adaptive?

mkorganashvili commented 6 years ago

inputstream.adaptive is binary addon, installed (but disabled in most cases) by default in kodi. So I use it as well to play mpd streams. The thing is, that, inputstream.adaptive needs to be enabled (in most cases, as i mentioned before) and also, needs additional libraries, such as widevine and etc. To make this plugin work, you have to do a lot dirty work: install/extract chrome and copy some dlls to the specific directory. inputstreamhelper does this dirty work for you, enables inputstream.adaptive if needed, installs missing libraries and stuff. Also, if mpd is not supported, gets message and reason in normal dialog window : )

xbrov01 commented 6 years ago

Hi I can confirm that the playback works (at least for the archive games}, a BIG thank you! Kodi did install all the necessary bits and pieces (and one very large piece - Chrome OS image). The video quality is unfortunately very poor though - I am running Kodi 17.6 on RPi2, I've built the plugin from mkorganashvili/master. I guess that the inputstream.adaptive is somehow involved in determining what bit rate should be used. Would you have any recommendation on how to configure it for the optimal performance?

Many thanks to all contributors...

mkorganashvili commented 6 years ago

@xbrov01 hey, good to know it worked. Quality is really poor, I have changed inputstream.adaptive settings to 1080p (you can try as well) but did not help :( I will let you know if i find solution

RolandasOnGithub commented 6 years ago

@mkorganashvili Sorry for being pedantic, but why your commits has empty commit message?

mkorganashvili commented 6 years ago

@pi-iuselinux-lt my bad, next time I will not leave it empty : )

MRLB commented 6 years ago

With Android (Kodi 18) I only get audio for about 1 minute without Video.

SNAPE15 commented 6 years ago

any luck with getting better quality video?

mkorganashvili commented 6 years ago

@SNAPE15 yep, you should get last commit

SNAPE15 commented 6 years ago

didnt work for me on archived game. still shows lower quality. but thank you for getting it working again.

mkorganashvili commented 6 years ago

Are you running kodi on fullscreen?

SNAPE15 commented 6 years ago

@mkorganashvili i am running a rpi3 with libreelec on a 40inch tv (filling screen). display settings for kodi are 1920x1080p. is that what you are meaning by fullscreen?

SNAPE15 commented 6 years ago

and you are meaning the 9d30338 commit?

mkorganashvili commented 6 years ago

@SNAPE15 did you change any of inputstream.adaptive settings?

SNAPE15 commented 6 years ago

@mkorganashvili no. tried on another rpi3 and still same. both using kodi v18 on libreelec

mkorganashvili commented 6 years ago

I have rpi3/kodi v17 and windows/kodi v8 and for both setups quality is good

SNAPE15 commented 6 years ago

@mkorganashvili what OS are u running kodi v17 on the rpi3?

mkorganashvili commented 6 years ago

@SNAPE15 libreelec

SNAPE15 commented 6 years ago

@mkorganashvili thanks. will try a fresh install of v17 on libreelec.

also, on live games. starts playing, after 20 seconds audio drops out. then video either keeps going or stops after another 20seconds. thoughts? previous days games works fine. just happens with LIve games

mkorganashvili commented 6 years ago

@SNAPE15 same for me :( I opened issue here https://github.com/peak3d/inputstream.adaptive/issues/135 and waiting for answer

maxgalbu commented 6 years ago

Changes are ok as of now, let's wait for the other module developer to respond

SNAPE15 commented 6 years ago

@mkorganashvili just to update you, i did a clean install on my rpi3's with libreelec and v17.6 kodi and am now getting the better quality streams on archived games. thanks.

also, looks like there is a fix for audio issue on live streams but only for v18 kodi :(

mkorganashvili commented 6 years ago

@SNAPE15 congrats : ))

is live playable at all?

ivankokan commented 5 years ago

Hi @mkorganashvili and @maxgalbu.

I am currently working on the second issue described here: https://github.com/maxgalbu/xbmc.plugin.video.nba/issues/87#issuecomment-433386361.

Just wanted to ask whether you find these else branches relevant anymore, should I keep them?

if '.mpd' in url:
  selected_video_url = url
else:
  # transform the url

Kind regards, Ivan