maxgalbu / xbmc.plugin.video.nba

Kodi plugin to watch NBA games with nba league pass
GNU General Public License v3.0
50 stars 43 forks source link

All possible fixes and updates since Nov 2018... #92

Open ivankokan opened 5 years ago

ivankokan commented 5 years ago

Hi @maxgalbu, are you still following what's going on here?

Resolves #56. Resolves #79. Resolves #83. Resolves #87. Resolves #88. Resolves #89. Resolves #90. Resolves #95. Resolves #96. Resolves #97. Resolves #99. Resolves #103. Resolves #104. Resolves #106. Resolves #107. Resolves #108.

joshjryan commented 5 years ago

Hi @maxgalbu, I have been using @ivankokan's branch for the past two weeks, and it successfully handles the exception being thrown when loading thumbnails on the Fire TV (falling back to old functionality of just displaying the home team, instead of creating an image composed of both team logos).

joshjryan commented 5 years ago

Hi @maxgalbu, With this merge request from @ivankokan's fork, and the new fixes that have gone into inputstream.adaptive (available in the latest xbmc nighly), this plugin now works on Amazon FireTV Sticks. It'd be great if we could get this change merged into your official repo, and get it updated in the official Kodi addon repository (where an old version of this plugin is currently listed). Let me know if there is anything I can do to help.

joshjryan commented 5 years ago

@ivankokan, because it has been 10 months since @maxgalbu's last commit, do you think we should assume he is no longer supporting this plugin? (if that's the case, @maxgalbu, thank you for all of your work to get this plugin where it is!)

If so, @ivankokan, would you be interested in submitting your repo to kodi to be added to the official repo? *I don't know if there is a process defined to update https://kodi.tv/addon/plugins-video-add-ons/nba-league-pass to point to your repo.

ivankokan commented 5 years ago

Hi @joshjryan, let's wait a bit more for @maxgalbu's answer before making any decision.

ivankokan commented 5 years ago

Hi @maxgalbu, are you still following what's going on here?

maxgalbu commented 5 years ago

Sorry, I'm no longer following this plugin, do you have the time to take care of it?

ivankokan commented 5 years ago

Sorry, I'm no longer following this plugin, do you have the time to take care of it?

It is better that someone takes care than no one - I can give a shot.

ivankokan commented 5 years ago

Hi @maxgalbu, how do we "transfer" everything?

ivankokan commented 5 years ago

Hi @maxgalbu. I see that the repository can be completely transferred through Settings (https://help.github.com/en/articles/transferring-a-repository). On the other hand, do we need to change things somewhere else within the Kodi community?

ivankokan commented 5 years ago

Hi @maxgalbu, any progress?

ivankokan commented 5 years ago

Hi @maxgalbu, it would be great if we welcome the new NBA season ready with all updates, fixes, and changes (I guess there are many to be covered as we had streaming issues at the end of last season). How do we "transfer" everything?

ivankokan commented 4 years ago

@joshjryan, have you tried the preseason, anything critical?

joshjryan commented 4 years ago

The Nuggets don't start playing games until next week :) I'll try one of the other games over the next day or two and let you know how it goes.

ivankokan commented 4 years ago

@maxgalbu Any updates?

ivankokan commented 4 years ago

@maxgalbu @joshjryan What do you suggest on the general matter add-on's future?

ivankokan commented 4 years ago

@maxgalbu @joshjryan What do you suggest on the general matter add-on's future?

I am ready to take over this one.

ivankokan commented 4 years ago

I linked all relevant issues so they eventually get automatically closed upon merging this PR.

ivankokan commented 4 years ago

NBA TV Live and Episodes are fixed now. It remains to sort out some ambiguities with timestamps.

larssb commented 4 years ago

How lovely it would be to get you @ivankokan to take this over. @maxgalbu would you be able to spend the time it requires to transfer the "keys" to Mr. Ivan Kokan. Please.

Thank you.

ivankokan commented 3 years ago

@maxgalbu Please?

Hi @maxgalbu. I see that the repository can be completely transferred through Settings (https://help.github.com/en/articles/transferring-a-repository). On the other hand, do we need to change things somewhere else within the Kodi community?