search

maxgerhardt / platform-raspberrypi

Raspberry Pi: development platform for PlatformIO
Apache License 2.0
94 stars 46 forks source link

Update main.py #4

Closed dlbogdan closed 2 years ago

dlbogdan commented 2 years ago

because of the logic selecting elf or firm (bin), we need to default to no offset on normal firmware upload because we already defaulted to elf a few lines below if upload.offset_address is not user set so when no offset is needed. programming fails otherwise Unfortunately, my way of modifying the code probably sucks because I've never written anything in python but I assumed the second arg is the default n case the first is missing. Haven't had time to dig too much into it.

maxgerhardt commented 2 years ago

Hm that all sounds logical, I'm just stunned how I never noticed that when uploading to my Pico via the Picoprobe o_o. Definitely added it in https://github.com/maxgerhardt/platform-raspberrypi/commit/c0653a3d761266b291c5567634df4933484b23bc a long time ago.

Will test with both variants to verify before merge.

dlbogdan commented 2 years ago

Well?

tkanarsky commented 2 years ago

aha, this seems to be the root cause of https://github.com/earlephilhower/arduino-pico/issues/571 which I ran into a few days back. +1 for this change, it works on my end

maxgerhardt commented 2 years ago

Thanks for the contribution, merged.

(Use pio platform update https://github.com/maxgerhardt/platform-raspberrypi.git to update your local installation)

tkanarsky commented 2 years ago

awesome! thanks for the quick turnaround :D