search

maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
6.99k stars 155 forks source link

Bring back longer unlock durations please? #345

Closed taxilian closed 2 years ago

taxilian commented 2 years ago

Hi, I recently updated to a newer nightly and was quite disappointed to find that the longest unlock duration is now 1h; 24h is a bit long, I admit, but couldn't we at least get some longer options? Honestly 8h would be ideal for me, but even 24h is fine as long as #332 pans out (and in my experience so far it does seem to re-lock when the system locks).

I tried to find an explanation of why 24h was removed but I couldn't find anything; I was all set to encourage all my coworkers to use it and then found my favorite feature had just become 10% as useful to me.

maxgoedjen commented 2 years ago

@taxilian basically I removed it because it hadn't been working in my testing... was it working for you? If it was I'll put it back.

taxilian commented 2 years ago

I won't swear that it was working for a full 24h, but it definitely was working for the afternoon =]

On Fri, Feb 11, 2022 at 7:51 PM Max Goedjen @.***> wrote:

@taxilian https://github.com/taxilian basically I removed it because it hadn't been working in my testing... was it working for you? If it was I'll put it back.

— Reply to this email directly, view it on GitHub https://github.com/maxgoedjen/secretive/issues/345#issuecomment-1036964184, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWYTR3ZGUW5BEM372IAODU2XDJZANCNFSM5OBKTCZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

maxgoedjen commented 2 years ago

@taxilian alrighty then, I'll revert this. If you'd do me a favor – can you keep track of how long it seems to be working? I'm pretty sure it won't work for 24h, but I'd definitely like to let it be whatever the practical limit of it is.

taxilian commented 2 years ago

I will do my best, however from my observations the limit seems to have been more due to other factors resetting it rather than time. For example:

I don't believe I've seen it lock again other than those two case, but I'll try to pay more attention.