maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
7.16k stars 158 forks source link

Signing workflow #441

Open gl-njanz opened 1 year ago

gl-njanz commented 1 year ago

afff88c47dab7a74774b19edca2df0a37937fa6a implements the Git SSH signing setup.

It lacks the ability to automatically set the user.signingkey-option, as

  1. They're not available at the time the setup is run
  2. Users might want to choose which secret will be used for signing (I sure do 😂 )

IMO setting this option should happen in either SecretDetailView.swift or SecretListItemView.swift, but I'll open an issue to discuss this (see Secretive is Opinionated)

2f2870dac49f5dcca9014db183f7be398ace889e is just me trying to appease Markdownlint. On the plus side, the APP_CONFIG.md is now a little more colorful.

gl-njanz commented 1 year ago

Hi @Kristy605, and welcome 🙃

The workflow on how to set up commit signing using Secretive SSH keys is explained better in #439: https://github.com/maxgoedjen/secretive/pull/439/files