search

maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
7.16k stars 157 forks source link

Added sorting to secret list #481

Open prawel opened 1 year ago

prawel commented 1 year ago

This PR adds sorting by secret name to secrets list sidebar.

taxilian commented 10 months ago

The concern I see with this is that the order it shows up in the sidebar is also the order that it presents them via the agent -- e.g. if you have more than one secret that is valid for a connection it will use them in the order presented.

Most of the time that probably isn't an issue, but if there was a way to manually change the order of secrets from a PIV usb key then this would be a big deal for me =]

I think the correct fix is to allow either manual or by name sorting, but it needs to sort them in the backend whatever that is, not just in the display -- because the order they are in does actually mean something.