maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
6.99k stars 155 forks source link

Switch concurrency warnings to complete #523

Open maxgoedjen opened 5 months ago

maxgoedjen commented 5 months ago

Once Xcode 15.4 is out.

PBHDK commented 2 months ago

Hi @maxgoedjen

Does this have to do with the following error, which is showing up for me in /Users/paul/src/secretive/Sources/Packages/Sources/SmartCardSecretKit/SmartCardStore.swift::120 for instance?

Instance methods of non-Sendable types cannot be marked as '@Sendable'; this is an error in Swift 6

I spent quite a while trying to debug this, but since it's code I didn't touch, I believe it might an issue with the (my?) current toolchain.

maxgoedjen commented 2 months ago

@PBHDK yeah, that's it – any time you see Sendability mentioned that's related to this, not anything wrong with your toolchain.

PBHDK commented 2 months ago

@maxgoedjen oh, that's unfortunate.

Is there an obvious workaround I'm missing? ATM, I'm not able to build because of this ...

maxgoedjen commented 2 months ago

@PBHDK for the moment, you can turn down the concurrency warnings – there's a few in Xcode settings, and a few in the package. Try setting them to "minimal" or "targeted".

PBHDK commented 2 months ago

Will do. Thanks, @maxgoedjen !