search

maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
6.99k stars 155 forks source link

Possible performance issues on macOS 14.5 #552

Open maxgoedjen opened 1 month ago

delfuego commented 1 month ago

Let us know if there's any info we can provide; I certainly am seeing much slower operation under macOS 14.5.

lenovouser commented 1 month ago

Have this as well, I commented in https://github.com/maxgoedjen/secretive/issues/543 yesterday, but what I am experiencing might more likely be this issue.

Manouchehri commented 3 weeks ago

Same! Thought I was going crazy.

guyboltonking commented 3 weeks ago

This appears to be an iTerm2 issue (I downgraded from 3.5.0 to 3.4.23 and the problem went away): https://gitlab.com/gnachman/iterm2/-/issues/11483#note_1932711066 (found in https://github.com/maxgoedjen/secretive/issues/543#issuecomment-2141660140).

delfuego commented 3 weeks ago

@guyboltonking HOLY CRAP. I wouldn't have ever thought to just try using Terminal.app to verify that a bug was in iTerm2... but sure enough, using Terminal, Secretive is instant.

maxgoedjen commented 3 weeks ago

That'd explain why I'm not really seeing it here – anyone experiencing this that's NOT using iTerm?

tardigradeus commented 3 weeks ago

Hi everyone, I don't know if it's related but i use git inside Intelijidea and it worked perfectly.

A recent update in one of my project result in 5 or 6 git action using an ssh key in secretive. Some time the project get stuck trying to clone or to fetch a dependancies and the pop up asking for the access key does not show.

origamislayer commented 3 weeks ago

Removing /Applications/iTerm.app/Contents/PlugIns/iTermFileProvider.appex fixes the issue for me, per the issue thread linked by @guyboltonking