search

maxgoedjen / secretive

Store SSH keys in the Secure Enclave
MIT License
7.23k stars 159 forks source link

[sequoia beta] ui issue: all keys are marked as "locked" #560

Open martinpaljak opened 3 months ago

martinpaljak commented 3 months ago

All keys in the key list have a padlock, even the ones that are functioning as "notify only"

maxgoedjen commented 3 months ago

Yeah, I can also reproduce this. Not clear to me yet if it's a Sequoia bug or just a change in some underlying behavior I'll have to update for.

martinpaljak commented 2 months ago

For me, all keys created before sequoia update show with a padlock. Keys crated with sequoia (incl. RC) look right all the time after creation. All keys work as expected, at least seem to.

maxgoedjen commented 2 months ago

https://github.com/maxgoedjen/secretive/blob/main/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift#L272

This is where it's happening. Basically there's not a proper way to inspect for the auth-required attribute, so I have been comparing them with a reference. Something in the construction of this object must've changed between versions though, giving us these false positives. If I can figure out a way to fix this soonish, I"ll do that, but I may just have to remove this feature :/