search

maxheld83 / ghactions

GitHub actions for R and accompanying R package
https://www.maxheld.de/ghactions/
MIT License
169 stars 17 forks source link

are actions still cached #315

Open maxheld83 opened 5 years ago

maxheld83 commented 5 years ago

maybe there's enough caching out of the box in the new gh actions

maxheld83 commented 5 years ago

it appears as per the above commit that action images are no longer cached. Calling them with a tag from docker "manually" will probably still get the tag, but there's no magical translation happening from GitHub repos, as there used to be.

If that is so then it's probably also unnecessary to publish images to docker hub in the first place, unless we're going the manual route.

Have to double check this, then ask support.

maxheld83 commented 5 years ago

above commits confirm that images are no longer pulled from docker hub, unless docker:// is explicitly given.

maxheld83 commented 5 years ago

AFAIK, the old, HCL-based GitHub actions would pull, not build, images for GitHub actions from Docker Hub when action images would be pushed and tagged properly (via the actions action).

For example,

action "GCP Authenticate" { uses = "actions/gcloud/auth@d124d4b82701480dc29e68bb73a87cfb2ce0b469" secrets = [ "GCLOUD_AUTH" ] }

would just pull docker://github/gcloud-auth:d124d4b82701480dc29e68bb73a87cfb2ce0b469.

For actions with bigger docker images, this could save a considerable amount of time.

This feature appears to be gone now.

Unless I specifically uses: docker:// the image always gets docker build first, which can take a long time.

This makes things easier, and the old magical way of tagging docker images with git shas and refs was always a bit weird.

I just want to know whether this feature: is coming back is coming back in another form (i.e. by using another registry under the hood or whatever) is not coming back, and I have to runs:: docker://... if I want to avoid docker build. Knowing this would be immensely helpful in building out our actions.

Also, perhaps other people might stumble over this and it might be worth pointing out this change in the docs?