search

maxheld83 / ghactions

GitHub actions for R and accompanying R package
https://www.maxheld.de/ghactions/
MIT License
169 stars 17 forks source link

accept string arrays for args #319

Open maxheld83 opened 5 years ago

maxheld83 commented 5 years ago

really inconvenient limitation

maxheld83 commented 5 years ago

from here:

A string that defines the inputs for a Docker container. Inputs can include hardcoded strings. GitHub passes the args to the container's ENTRYPOINT when the container starts up. An array of strings is not supported by this parameter.

somewhat inconvenient for lots of arguments.

wrote support

maxheld83 commented 5 years ago

email to support:

Hi octocats,

This is about the new YAML-based GitHub actions.

Your docs state for the above:

A string that defines the inputs for a Docker container. Inputs can include hardcoded strings. GitHub passes the args to the container's ENTRYPOINT when the container starts up. An array of strings is not supported by this parameter.

That's actually pretty inconvenient for cases with logs of arguments.

For example, I have an action that wraps the pandoc conversion CLI tool: http://github.com/maxheld83/pandoc

It has a lot of arguments, they change frequently, and I wouldn't want to copy them all as inputs in my wrapper action and then have users of that action provide them as jobs.<job_id>.steps.with. That would be nice, but the maintenance load would be insane. I guess that's similar for a lot of CLI tools with lots of arguments.

So I'd just like users to be able to conveniently pass through arguments to entrypoint with jobs.<job_id>.steps.with.args, but passing that all as one string is awkward and makes versioning ugly.

Any chance you could support arrays of strings here?

Or what would be the idiomatic/first-best-way to pass on lots of arguments?