search

maxheld83 / pensieve

R package for the scientific study of human subjectivity.
https://www.maxheld.de/pensieve
GNU Affero General Public License v3.0
11 stars 2 forks source link

factor out all manual error messages from validate_S3 methods #423

Open maxheld83 opened 6 years ago

maxheld83 commented 6 years ago

manual stop() will not hand off error messages to ps_coll, and will therefore pre-empt all other ps_coll messages. ps_coll mechanism should be used everywhere, otherwise error messages are often useless.

maxheld83 commented 6 years ago

frustratingly, once these bugs are fixed, a bunch of tests will fail, because we currently often expect_error(validate_S3)), though proper validate_S3()s will never actually return an error, but a character msg.