search

maxhodak / keras-molecules

Autoencoder network for learning a continuous representation of molecular structures.
MIT License
519 stars 146 forks source link

switch to keras pip? #37

Open dakoner opened 7 years ago

dakoner commented 7 years ago

Currently the requirements.txt file references keras from git: -e git+https://github.com/fchollet/keras.git#egg=keras

however, keras is in PyPI.

if it's not impossible, I suggest using the one from pip with a defined version number, should make it less likely to get hit by future upgrades to the Keras API.

maxhodak commented 7 years ago

ReduceLROnPlateau wasn't in a numbered release yet which is why I changed it to pulling from git. If they're caught up we can change back.

pechersky commented 7 years ago

According to https://github.com/fchollet/keras/compare/1.1.0...1.1.1, ReduceLRonPlateau is in 1.1.1.

pechersky commented 7 years ago

Version 1.1.1 works for me. If it works for you as well, we'll merge in.

hsiaoyi0504 commented 7 years ago

Maybe >= 1.1.1 will be better? Why need to constrain specific version?