maxhoesel-ansible / ansible-collection-proxmox

A collection for managing Proxmox VE hosts and their guests
38 stars 8 forks source link

pve: Enterprise url for repo doesn't match PVE 7 #98

Open rasmuslp opened 1 year ago

rasmuslp commented 1 year ago

On a fresh install of Proxmox VE 7.2-3 running maxhoesel.proxmox.pve 5.0.1 with all defaults, I get an unexpected result with how the repository urls gets handled.

It correctly adds pve-no-subscription, but fails to remove / disable pve-enterprise, as the url is https://enterprise.proxmox.com/debian/pve.

This causes it to fail updating the APT cache as it's unauthorised for the enterprise repo.

maxhoesel commented 1 year ago

Thanks for the bug report! I'm pretty busy right now due to other obligations, so it might be a while before I get around to it.

That said, I've been looking into testing the roles in this collection more thoroughly for some time now. Once I get around to that, I'll make sure to include a fix for this issue too!

psyciknz commented 5 months ago

I added:

- name: Other PVE repositories are disabled
  apt_repository:
    repo: "deb https://enterprise.proxmox.com/debian/pve {{ ansible_distribution_release }} {{ pve_repo_names[item] }}"
    state: absent
    filename: "{{ pve_repo_names[item] }}"
    update_cache: no
  loop: "{{ pve_disable_repos }}"

which removed https://enterprise.proxmox.com/debian/pve bookworm pve-enterprise

But then it also seemed to complain about: https://enterprise.proxmox.com/debian/ceph-quincy/dists/bookworm/InRelease

BeyondEvil commented 1 month ago

Here's what I do for PVE 8.2

    - name: Set the "no-subscription" repositories
      ansible.builtin.apt_repository:
        filename: "{{ item.filename }}"
        repo: "deb http://download.proxmox.com/debian/{{ item.repo }} bookworm {{ item.package }}"
        state: present
        update_cache: false
      loop:
        - {filename: pve-no-subscription, repo: pve, package: pve-no-subscription}
        - {filename: ceph, repo: ceph-quincy, package: no-subscription}

    - name: Remove the "pve-enterprise" repository
      ansible.builtin.apt_repository:
        filename: "{{ item.filename }}"
        repo: "deb https://enterprise.proxmox.com/debian/{{ item.repo }} bookworm {{ item.package }}"
        state: absent
        update_cache: false
      loop:
        - {filename: pve-enterprise, repo: pve, package: pve-enterprise}
        - {filename: ceph, repo: ceph-quincy, package: enterprise}

    - name: Update APT cache
      ansible.builtin.apt:
        update_cache: yes