search

maxhu08 / mtab

🌴 lightweight new tab page extension
https://get-mtab.vercel.app
MIT License
339 stars 11 forks source link

Favicon doesnt load immediately #23

Closed NotAriRay closed 3 months ago

NotAriRay commented 3 months ago

https://github.com/user-attachments/assets/723d08a6-e57e-43a1-b22d-054e9f807f98

Tittle basically, also added a video to clarify the issue

maxhu08 commented 3 months ago

Not sure how I could fix this, I don't get control over how fast the favicon loads.

NotAriRay commented 3 months ago

Maybe loading the page only after the config is fully loaded?

maxhu08 commented 3 months ago

The config does get loaded first, but it takes time for the javascipt to execute.

Or do you mean the mtab logo appearing before the custom one?

maxhu08 commented 3 months ago

I can make it not load the default mtab logo first but that'll result in no logo for a split second.

https://github.com/user-attachments/assets/c13a446c-5d8c-47f2-80fb-0220172ad3f2

NotAriRay commented 3 months ago

That's better but I feel like I might be able to fix it, give me a bit lol

NotAriRay commented 3 months ago

Nvm this shit too hard

maxhu08 commented 3 months ago

Ok lol, is the video I shared earlier good then?

NotAriRay commented 3 months ago

I mean yeah its better, i'll close the issue with this comment ig