Closed elzadj closed 5 months ago
Fixed, leaving it open until we test on several sites.
Here is the summary of issues that need attention in a numbered list, ready to be added to GitHub:
Prompt: Used in Groq Lama 3 70B https://groq.com/ 305.37 Tokens per seconds
Role: Professional QA tester and github issue creators. Task: please summarize all the issues that need attention in this chat thread
- a numbered list so i can add them to github.
- Add a placeholder for images when missing.
- Note speaker names. Retain key details like browsers etc Format: Output numbered list in markdown ready for a github issue. (Paste anonymised chat thread)
Issues:
[x] 1. Crash in Site Editor: Crash occurs when trying to open the pages view in Firefox. Christiaan, 11:23
[x] 2. (Same as point 1) DeadObject error: Error occurs in Firefox. Christiaan, 11:27
[x] 3. (combination of 1 and 6) Slow loading in Firefox: Site Editor loads slowly in Firefox compared to Chrome. Christiaan, 11:42
[x] 4. Missing image on SEARCH Template: One image is missing on the search page. Christiaan, 11:43
[x] 5. Page Editor styles: Page Editor styles are odd, and the title is left-aligned. Christiaan, 11:49
[x] 6. EDGE EE infinite SVG migrator loop: Infinite SVG migrator loop occurs in EDGE EE, taking around 5 minutes to stop before the console loads for errors. Christiaan, 8 min
[x] 7. infinite Transition attributes migrator loop: same as previous point, but for Transition attributes migrator.
Notes:
CPT templates https://github.com/maxi-blocks/maxi-blocks/issues/5587
native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used
native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used
Have you tried the Styles Section in the site editor? I saw some blocks start styles there. I wonder if we can update (margin-block-start: 24px) in our theme.json file @elzadj @Olekrut ?
I wonder if we can update (margin-block-start: 24px) in our theme.json file
there is no such thing there, but I can add styles for the entry-content area to make it 0
console logs index-template-edit-block-crash-chrome-console.txt
error log on theme activation.
[04-Jun-2024 16:30:34 UTC] PHP Deprecated: Automatic conversion of false to array is deprecated in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/themes/maxiblocks/functions.php on line 489
[04-Jun-2024 16:31:07 UTC] PHP Fatal error: Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, WP_REST_Request given in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php:594
Stack trace:
#0 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1230): MaxiBlocks_API->post_maxi_blocks_sc_string()
#1 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1063): WP_REST_Server->respond_to_request()
#2 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(439): WP_REST_Server->dispatch()
#3 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api.php(428): WP_REST_Server->serve_request()
#4 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(324): rest_api_loaded()
#5 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#6 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/plugin.php(565): WP_Hook->do_action()
#7 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(418): do_action_ref_array()
#8 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(813): WP->parse_request()
#9 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/functions.php(1336): WP->main()
#10 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-blog-header.php(16): wp()
#11 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/index.php(17): require('...')
#12 {main}
thrown in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php on line 594
Code editor
<!-- wp:template-part {"slug":"header","theme":"maxiblocks"} /-->
<!-- wp:group {"tagName":"main","align":"full","style":{"spacing":{"padding":{"top":"0","bottom":"0","left":"0%","right":"0%"}}},"layout":{"type":"constrained"}} -->
<main
class="wp-block-group alignfull"
style="
padding-top: 0;
padding-right: 0%;
padding-bottom: 0;
padding-left: 0%;
"
>
<!-- wp:post-content {"style":{"spacing":{"blockGap":"0"}}} /-->
</main>
<!-- /wp:group -->
<!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer","theme":"maxiblocks"} /-->
======
2. Found this pattern export function from "My patterns" but there is no menu item for it? Odd https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
===== 3. Here ui styles are missing for some reason. blob:https://maxitheme.instawp.xyz/03f61330-570d-4916-9d3d-8ab293cd8dad
===
Made a new blog post and this happened with the single post template. https://maxitheme.instawp.xyz/hello-world/
Realised the blog post template did not have a Gutenberg "Content" area to i tried to add one. Then the bg colour is white - even though i set it to black background ons the content block and on the Column Maxi which contains it. No change. https://maxitheme.instawp.xyz/hello-world/
Aha i figured it out. In the blog post Editing Experience EE you basically just use text, image, video (not container, row and column). You basically need to imagine the VE Visitor experience side and what it will look like.
A new post https://maxitheme.instawp.xyz/wp-admin/post-new.php Just gives you nothing - see screenshot. Is this still an FSE ui shortcoming? IE there is no solution for it yet?
Feels odd when the single blog post template is not loaded in the EE Visual editor when it is active. It make the writing experience odd. Is there an option to load it in the EE - i'm not sure how it works - just thinking of a way that will improve the user experience cos now its kinda weird. Not sure what can be done - its very different from the classic editor where you have an input field the the post content. When i get a blank page for a post it im srt of still in the "oh i have to design it" mode versus "just start writing. I wonder what we can do to make it more intuitive?
Maybe it should feel more like a Writing Experience? Lol i found "distraction free mode" under preferences and now i dont even have a save button.
Found it - you hover top of the screen then it shows the toolbar. In this view the Maxi Master Toolbar Icon doesn't work.
Is there any way for themes or plugins to control the editor styles for the Blog writing Experience?
Ok that's all i have for now. More to follow.
Check the plugin notice - Installation button (when the plugin is not installed)
- Found this pattern export function from "My patterns" but there is no menu item for it? Odd https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
Summarizing the issues to fix:
No pulses for me when inserting patterns from blog posts creation flow https://maxitheme.instawp.xyz/wp-admin/post-new.php Just nothing and then it appears. Then when a try to CTRL A - Delete - then the pulse work when im trying to delete.
Warning: Internal React error: Expected static flag was missing. Please notify the React team. is the console error. x 27
https://jam.dev/c/701417aa-4b0d-4963-8468-02436a8ea3e2
Same react errors on page creation flow - no pulses. Then when you want to start editing when you click on the block - it pulses just for that block you click on. https://maxitheme.instawp.xyz/wp-admin/post.php?post=99&action=edit
3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason." https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
Still can't see / re-create it, so a video would be nice :pouting_cat:
3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason." https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
Still can't see / re-create it, so a video would be nice 😾
Now i cannot recreate it either. Move on.
https://github.com/maxi-blocks/maxi-blocks/issues/5555