maxi-blocks / maxiblocks-theme

MaxiBlocks Go theme: Build professional websites fast with pre-made patterns, templates, and customisable icons. Perfect for web pros, it offers extensive customisation and responsive controls. Create high-quality sites efficiently, solo or as an agency. Reduce coding time and focus on business growth. Try MaxiBlocks Go for faster web design.
https://maxiblocks.com
Other
7 stars 0 forks source link

Beta's bugs - Round # 4 #1

Closed elzadj closed 5 months ago

elzadj commented 6 months ago

https://github.com/maxi-blocks/maxi-blocks/issues/5555

elzadj commented 6 months ago

Fixed, leaving it open until we test on several sites.

ckp267 commented 6 months ago

Here is the summary of issues that need attention in a numbered list, ready to be added to GitHub:

Prompt: Used in Groq Lama 3 70B https://groq.com/ 305.37 Tokens per seconds

Role: Professional QA tester and github issue creators. Task: please summarize all the issues that need attention in this chat thread

  1. a numbered list so i can add them to github.
  2. Add a placeholder for images when missing.
  3. Note speaker names. Retain key details like browsers etc Format: Output numbered list in markdown ready for a github issue. (Paste anonymised chat thread)

Issues:

Notes:

kyrapieterse commented 6 months ago

image

elzadj commented 6 months ago
elzadj commented 5 months ago

CPT templates https://github.com/maxi-blocks/maxi-blocks/issues/5587

Olekrut commented 5 months ago

native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used image

ckp267 commented 5 months ago

native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used image

Have you tried the Styles Section in the site editor? I saw some blocks start styles there. I wonder if we can update (margin-block-start: 24px) in our theme.json file @elzadj @Olekrut ?

elzadj commented 5 months ago

I wonder if we can update (margin-block-start: 24px) in our theme.json file

there is no such thing there, but I can add styles for the entry-content area to make it 0

ckp267 commented 5 months ago
  1. Block crash https://maxitheme.instawp.xyz/wp-admin/post.php?post=18&action=edit

image

image

console logs index-template-edit-block-crash-chrome-console.txt

error log on theme activation.

[04-Jun-2024 16:30:34 UTC] PHP Deprecated:  Automatic conversion of false to array is deprecated in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/themes/maxiblocks/functions.php on line 489
[04-Jun-2024 16:31:07 UTC] PHP Fatal error:  Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, WP_REST_Request given in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php:594
Stack trace:
#0 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1230): MaxiBlocks_API->post_maxi_blocks_sc_string()
#1 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1063): WP_REST_Server->respond_to_request()
#2 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(439): WP_REST_Server->dispatch()
#3 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api.php(428): WP_REST_Server->serve_request()
#4 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(324): rest_api_loaded()
#5 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#6 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/plugin.php(565): WP_Hook->do_action()
#7 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(418): do_action_ref_array()
#8 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(813): WP->parse_request()
#9 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/functions.php(1336): WP->main()
#10 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-blog-header.php(16): wp()
#11 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/index.php(17): require('...')
#12 {main}
  thrown in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php on line 594

Code editor

<!-- wp:template-part {"slug":"header","theme":"maxiblocks"} /-->

<!-- wp:group {"tagName":"main","align":"full","style":{"spacing":{"padding":{"top":"0","bottom":"0","left":"0%","right":"0%"}}},"layout":{"type":"constrained"}} -->
<main
    class="wp-block-group alignfull"
    style="
        padding-top: 0;
        padding-right: 0%;
        padding-bottom: 0;
        padding-left: 0%;
    "
>
    <!-- wp:post-content {"style":{"spacing":{"blockGap":"0"}}} /-->
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer","theme":"maxiblocks"} /-->

======

2. Found this pattern export function from "My patterns" but there is no menu item for it? Odd https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block image

===== 3. Here ui styles are missing for some reason. blob:https://maxitheme.instawp.xyz/03f61330-570d-4916-9d3d-8ab293cd8dad image

image

===

  1. THIS IS JUST COMMENTARY ON THE POST WRITING EXPERIENCE - not bugs. Just thoughts on how we might improve it.

Made a new blog post and this happened with the single post template. https://maxitheme.instawp.xyz/hello-world/

image

Realised the blog post template did not have a Gutenberg "Content" area to i tried to add one. Then the bg colour is white - even though i set it to black background ons the content block and on the Column Maxi which contains it. No change. https://maxitheme.instawp.xyz/hello-world/

Aha i figured it out. In the blog post Editing Experience EE you basically just use text, image, video (not container, row and column). You basically need to imagine the VE Visitor experience side and what it will look like.

A new post https://maxitheme.instawp.xyz/wp-admin/post-new.php Just gives you nothing - see screenshot. Is this still an FSE ui shortcoming? IE there is no solution for it yet? image

Feels odd when the single blog post template is not loaded in the EE Visual editor when it is active. It make the writing experience odd. Is there an option to load it in the EE - i'm not sure how it works - just thinking of a way that will improve the user experience cos now its kinda weird. Not sure what can be done - its very different from the classic editor where you have an input field the the post content. When i get a blank page for a post it im srt of still in the "oh i have to design it" mode versus "just start writing. I wonder what we can do to make it more intuitive?

Maybe it should feel more like a Writing Experience? Lol i found "distraction free mode" under preferences and now i dont even have a save button.

image

Found it - you hover top of the screen then it shows the toolbar. In this view the Maxi Master Toolbar Icon doesn't work.

image

Is there any way for themes or plugins to control the editor styles for the Blog writing Experience?


Ok that's all i have for now. More to follow.

elzadj commented 5 months ago

Check the plugin notice - Installation button (when the plugin is not installed)

elzadj commented 5 months ago
  1. Found this pattern export function from "My patterns" but there is no menu item for it? Odd https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

screenshot-wordpress local-2024 06 05-12_15_33

elzadj commented 5 months ago
  1. I can't re-create it on https://maxitheme.instawp.xyz/wp-admin/post.php?post=1&action=edit , would be great to get a video. Note: you can't open a blog, it usually used for iframes in gutenberg https://developer.mozilla.org/en-US/docs/Web/API/Blob
elzadj commented 5 months ago

Summarizing the issues to fix:

ckp267 commented 5 months ago

No pulses for me when inserting patterns from blog posts creation flow https://maxitheme.instawp.xyz/wp-admin/post-new.php Just nothing and then it appears. Then when a try to CTRL A - Delete - then the pulse work when im trying to delete.

Warning: Internal React error: Expected static flag was missing. Please notify the React team. is the console error. x 27

https://jam.dev/c/701417aa-4b0d-4963-8468-02436a8ea3e2

Same react errors on page creation flow - no pulses. Then when you want to start editing when you click on the block - it pulses just for that block you click on. https://maxitheme.instawp.xyz/wp-admin/post.php?post=99&action=edit

elzadj commented 5 months ago

3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason." https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

Still can't see / re-create it, so a video would be nice :pouting_cat:

ckp267 commented 5 months ago

3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason." https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

Still can't see / re-create it, so a video would be nice 😾

Now i cannot recreate it either. Move on.