search

maxiberta / htop-snap

The `htop` utility packaged as a snap.
MIT License
19 stars 4 forks source link

ENV lost when executing htop #2

Closed pachulo closed 6 years ago

pachulo commented 6 years ago

I think that something is wrong with the ENV when executing htop, because, for example, when I choose the "Tree" view, the "lines" are drawn using ASCII: image

But if I execute the binary directly, like this:

$ /snap/htop/current/bin/htop

UTF-8 characters are used:

image

maxiberta commented 6 years ago

Hi! Thanks for the report. The environment is not lost when running the snap, as shown by snap run --shell htop -c env. But what's missing seems to be the precompiled locale definitions for all locales, except the default C, C.UTF-8 and POSIX (as shown by snap run --shell htop -c "locale -a").

I've (hopefully) fixed it by bundling all base text locales with the htop snap, and adding a small wrapper script that generates the binary locale on the first run if needed (from the LANG envvar), and caches it in $SNAP_USER_COMMON/locale (i.e. $HOME/snap/htop/common/locale). This is now published in the candidate channel, waiting for feedback before promoting to stable. Please let me know if it works for you :-)

Thanks again!

pachulo commented 6 years ago

Wow, that was fast! I was wrong then: tested it and it works OK now, thanks a lot!!!

maxiberta commented 6 years ago

The updated snap is now published on the stable channel.