maxim-kolesnikov / react-native-heic-converter

Convert your HEIC files with React Native
MIT License
70 stars 23 forks source link

Update node version to the latest tagged version #27

Closed ineedthekeyboard closed 2 years ago

ineedthekeyboard commented 3 years ago

Node shows the latest built version as 1.3.0.. when you have the latest tagged release at 1.3.1

estani commented 2 years ago

and v1.3.0 pin react-native to '^0.42.2' And for dome reason unknown to me, npm thinks that 0.63.4 is not in 0.42.2 range...

npm ERR! While resolving: react-native-heic-converter@1.3.0
npm ERR! Found: react-native@0.63.4
npm ERR! node_modules/react-native
npm ERR!   react-native@"0.63.4" from the root project
npm ERR!   peer react-native@">=0.63.0" from @codler/react-native-keyboard-aware-scroll-view@1.0.1
npm ERR!   node_modules/@codler/react-native-keyboard-aware-scroll-view
npm ERR!     @codler/react-native-keyboard-aware-scroll-view@"1.0.1" from native-base@2.15.2
npm ERR!     node_modules/native-base
npm ERR!       native-base@"^2.13.12" from @comjoo/ui-kit-mobile@1.2.0
npm ERR!       node_modules/@comjoo/ui-kit-mobile
npm ERR!         @comjoo/ui-kit-mobile@"^1.2.0" from the root project
npm ERR!   42 more (@comjoo/easy-core, react-native-image-crop-picker, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react-native@"^0.41.2" from react-native-heic-converter@1.3.0
npm ERR! node_modules/react-native-heic-converter
npm ERR!   react-native-heic-converter@"^1.3.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react-native@0.41.2
npm ERR! node_modules/react-native
npm ERR!   peer react-native@"^0.41.2" from react-native-heic-converter@1.3.0
npm ERR!   node_modules/react-native-heic-converter
npm ERR!     react-native-heic-converter@"^1.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry

this page thinks like I do: https://jubianchi.github.io/semver-check/#/^0.41.2/0.63.4

maxim-kolesnikov commented 2 years ago

https://github.com/maxim-kolesnikov/react-native-heic-converter/compare

tendolukwago commented 2 years ago

https://github.com/maxim-kolesnikov/react-native-heic-converter/compare

I'm confused by this comment. I believe the problem was that this was never released to NPM.

https://www.npmjs.com/package/react-native-heic-converter

Jake-Kuznicki commented 2 years ago

Bumping this, the tag 1.3.1 on the repository was successful but never released on NPM. @maxim-kolesnikov

image
maxim-kolesnikov commented 2 years ago

Resolved

image
maxim-kolesnikov commented 2 years ago

Please open a new issue if you are still having trouble.