search

maxim-kolesnikov / react-native-heic-converter

Convert your HEIC files with React Native
MIT License
68 stars 23 forks source link

Update react-native-windows to optional peer dependency #48

Closed floydkim closed 5 months ago

floydkim commented 5 months ago

Thanks for creating such a useful library.

react-native-windows is not essential for most react-native projects, and doesn't seem to be related to the behavior of react-native-heic-converter.

Sadly, react-native-heic-converter is the only library that makes me install react-native-windows in my project, and the several other libraries have been setting react-native-windows as an optional peer dependency.

Please merge this change and release it to npm. Thank you.

floydkim commented 5 months ago

Hi, @maxim-kolesnikov. Please review this PR :)

maxim-kolesnikov commented 5 months ago

https://github.com/maxim-kolesnikov/react-native-heic-converter/pull/47/files

floydkim commented 5 months ago

@maxim-kolesnikov thank you! Could you please publish to npm?