search

maxim-kolesnikov / react-native-heic-converter

Convert your HEIC files with React Native
MIT License
68 stars 23 forks source link

Fix for the new CameraRoll format `ph://XXXX/XX/XX` #9

Closed netbull closed 5 years ago

netbull commented 5 years ago

sorry for the mess with the commits... it's my first time when I play with native module...

netbull commented 5 years ago

@maxim-kolesnikov is there any change to review the PR? Currently the converter does not work with RN 60

maxim-kolesnikov commented 5 years ago

@netbull I can check it on weekend, but I want publish version with alpha tag name now.. Could you try send this path instead of using filename?

ph://CC95F08C-88C3-4012-9D6D-64A413D254B3/L0/001/IMG_0111.HEIC

Please look this https://github.com/maxim-kolesnikov/react-native-heic-converter/issues/3#issuecomment-509965195, I think it could work.

netbull commented 5 years ago

@maxim-kolesnikov thanks!

ph://CC95F08C-88C3-4012-9D6D-64A413D254B3/L0/001/IMG_0111.HEIC throws an error Can't write file

maxim-kolesnikov commented 5 years ago

@netbull 

yarn add react-native-heic-converter@alpha

or 

"dependencies": {
  "react-native-heic-converter": "1.2.2-alpha.0"
}
netbull commented 5 years ago

@maxim-kolesnikov thanks, already did it :) I guess I can delete the fork now.

maxim-kolesnikov commented 5 years ago

@netbull

ph://CC95F08C-88C3-4012-9D6D-64A413D254B3/L0/001/IMG_0111.HEIC throws an error Can't write file

Did you change folder key when try?

ph://XXXX/XX/XX/YOUR_IMG_FILENAME.HEIC

Path from CameraRoll ph://XXXX/XX/XX/ + YOUR_IMG_FILENAME.HEIC

netbull commented 5 years ago

No, I just did ${photo.uri}/${photo.filename} where photo is just the object from the CameraRoll

Also I tried to remove the ph://, but with same error.

maxim-kolesnikov commented 5 years ago

@netbull ok, thx