search

maxim-lobanov / setup-cocoapods

Set up your GitHub Actions workflow with a specific version of Cocoapods
MIT License
31 stars 6 forks source link

Permit run on linux? #3

Closed robhogan closed 4 years ago

robhogan commented 4 years ago

Cocoapods supports linux, at least in a limited way.

I have a React Native project and I'd like to add a CI step to validate Podfile.lock by running pod install after npm ci and checking that the lockfile doesn't change - theoretically this should work fine on linux, and if so it avoids an expensive macos build.

Is there any particular reason this action is blocked from running on linux? Would you be open to adding support if I worked on a PR?

maxim-lobanov commented 4 years ago

Hello @rh389 ! The single reason why I have limited it to macOS, I was not aware that it is possible to run cocoapods on Linux image. If it works and cover your use-case, I don't mind to add support. Do we need just extend os condition or any other logic is required for Linux? Please let me know how can I assist you.

robhogan commented 4 years ago

Hi Maxim,

I've just tried this out by simply removing the OS check and everything appears to work just fine on an ubuntu base image (I have one stubborn pod that won't build under linux, but that's a separate issue!).

I guess just widening that guard to allow process.platform === 'linux' would be neater, but it doesn't seem that there's anything more required than that.

maxim-lobanov commented 4 years ago

Great, will be very appreciate for your PR and contribution! Also, could you please update .github/workflows/test.yml file to add one more test case to ubuntu-latest.

maxim-lobanov commented 4 years ago

@rh389 , thank you for your contribution! I have released v1.1 to GA Marketplace. It should be available as uses: maxim-lobanov/setup-cocoapods@v1.1

robhogan commented 4 years ago

Perfect, thanks for the super-quick turnaround, and thanks for the package!