Error when requested version not available

daveisfera commented 8 months ago

The documentation stats that 15.1 should be available on macOS 13, but I believe it has to be downloaded/cached to the instance or something so there are times when it's not available. Could setup-xcode perform the necessary action when it's not available?

Here's the output from a time it failed

Run maxim-lobanov/setup-xcode@v1.6.0
Switching Xcode to version '~15.1.0'...
Available versions:
┌─────────┬──────────┬─────────────┬─────────────┬────────┬──────────────────────────────────┐
│ (index) │ version  │ buildNumber │ releaseType │ stable │               path               │
├─────────┼──────────┼─────────────┼─────────────┼────────┼──────────────────────────────────┤
│    0    │ '15.0.1' │  '15A507'   │    'GM'     │  true  │ '/Applications/Xcode_15.0.1.app' │
│    1    │ '14.3.1' │  '14E300c'  │    'GM'     │  true  │ '/Applications/Xcode_14.3.1.app' │
│    2    │ '14.2.0' │   '14C18'   │    'GM'     │  true  │  '/Applications/Xcode_14.2.app'  │
│    3    │ '14.1.0' │  '14B47b'   │    'GM'     │  true  │  '/Applications/Xcode_14.1.app'  │
└─────────┴──────────┴─────────────┴─────────────┴────────┴──────────────────────────────────┘
Error: Could not find Xcode version that satisfied version spec: '~15.1.0'

maxim-lobanov commented 8 months ago

Hi @daveisfera , Could you please check the image version in workflow run logs ("Set up job" step) and confirm that it is equal to 20231218.2 or newer? In past, I have seen problems when not all macOS VMs were updated properly to new image version and workflow was randomly assigned to outdated VMs. If it is our case, we should escalate this problem in https://github.com/actions/runner-images repo.

Could setup-xcode perform the necessary action when it's not available?

Unfortunately, it is not possible because:

Xcode installation takes ~20-30 minutes. I guess it is not acceptable to add 20-30 minutes to every workflow run.
It is not possible to download Xcode without auth on apple.com. If action installs Xcode in runtime, you would need to provide your apple login and password to the action which causes security risks. Also, afaik, Apple forces all accounts to have 2-factor-auth which makes it impossible to download Xcode during workflow run without user interaction.

So we can only rely on pre-installed versions of Xcode on macOS images provided by GitHub

daveisfera commented 8 months ago

That makes sense and thanks for the response.

I opened an issue with the runner-images because I think it's something wrong there and I believe it should be working from the perspective of this action.

For reference, here's the info from Set up job:

Current runner version: '2.311.0'
Operating System
  macOS
  13.6.3
  22G436
Runner Image
  Image: macos-13-arm64
  Version: 20231218.3
  Included Software: https://github.com/actions/runner-images/blob/macOS-13/20231218.3/images/macos/macos-13-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-13%2F20231218.3
Runner Image Provisioner
  2.0.321.1
GITHUB_TOKEN Permissions
  Actions: write
  Checks: write
  Contents: write
  Deployments: write
  Discussions: write
  Issues: write
  Metadata: read
  Packages: write
  Pages: write
  PullRequests: write
  RepositoryProjects: write
  SecurityEvents: write
  Statuses: write
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4.1.1' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'extractions/netrc@v1.4.0' (SHA:938ddbfb73b4efee33e57db13aba434b35af2f93)
Download action repository 'actions/setup-node@v4.0.1' (SHA:b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8)
Download action repository 'actions/cache@v3.3.2' (SHA:704facf57e6136b1bc63b828d79edcd491f0ee84)
Download action repository 'maxim-lobanov/setup-xcode@v1.6.0' (SHA:60606e260d2fc5762a71e64e74b2174e8ea3c8bd)
Complete job name: build_ios

daveisfera commented 8 months ago

And then here's one that failed (which lines up with it being an older version like you mentioned):

Current runner version: '2.311.0'
Operating System
  macOS
  13.6.1
  22G313
Runner Image
  Image: macos-13-arm64
  Version: 20231205.1
  Included Software: https://github.com/actions/runner-images/blob/macOS-13/20231205.1/images/macos/macos-13-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-13%2F20231205.1
Runner Image Provisioner
  2.0.321.1
GITHUB_TOKEN Permissions
  Actions: write
  Checks: write
  Contents: write
  Deployments: write
  Discussions: write
  Issues: write
  Metadata: read
  Packages: write
  Pages: write
  PullRequests: write
  RepositoryProjects: write
  SecurityEvents: write
  Statuses: write
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4.1.1' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'extractions/netrc@v1.4.0' (SHA:938ddbfb73b4efee33e57db13aba434b35af2f93)
Download action repository 'actions/setup-node@v4.0.1' (SHA:b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8)
Download action repository 'actions/cache@v3.3.2' (SHA:704facf57e6136b1bc63b828d79edcd491f0ee84)
Download action repository 'maxim-lobanov/setup-xcode@v1.6.0' (SHA:60606e260d2fc5762a71e64e74b2174e8ea3c8bd)
Complete job name: build_ios

maxim-lobanov commented 8 months ago

Closing this issue since it was an issue on runner-images side

maxim-lobanov / setup-xcode

Error when requested version not available #74