maxim-saplin / data_table_2

In-place substitute for Flutter's DataTable and PaginatedDataTable with fixed/sticky header and extra features
https://pub.dev/packages/data_table_2
BSD 3-Clause "New" or "Revised" License
203 stars 140 forks source link

Disable Visible Horizontal Scrollbar on IOS #192

Closed DimaOstrovskyiEk closed 1 year ago

DimaOstrovskyiEk commented 1 year ago

No option to disable the visible horizontal scrollbar on IOS with DataTable2

maxim-saplin commented 1 year ago

https://github.com/maxim-saplin/data_table_2/issues/140#issuecomment-1255413900

DimaOstrovskyiEk commented 1 year ago

@maxim-saplin I tried to play with themes. On android this managed to disable horizontal scrollbar, but not on IOS.

DimaOstrovskyiEk commented 1 year ago

@maxim-saplin After reviewing your code, I found Scrollbar. If you want to not show it, add a condition on which you will render it. Or use RawScrollbar with

thumbColor: Colors.transparent,
trackColor: Colors.transparent

or thickness: 0

maxim-saplin commented 1 year ago

There're actually plenty of scroll views with scrollbars and scroll configurations which are there to mae fixed cols/rows happen and frankly speaking it is the part I was always affraid of to touch... I don't think the approach of surfacing some property will be a good approach for all use cases. I beleive themes should work and they worked on most platforms, except iOS... Need some time to look closer at what's in the code

maxim-saplin commented 1 year ago

For the record, Scrollbar internally picks to use either Material or Cupertino scrollbar, the letter one ignores style: https://github.com/flutter/flutter/issues/36603

maxim-saplin commented 1 year ago

@DimaOstrovskyiEk could you please check master branch, I've added fixes that:

DimaOstrovskyiEk commented 1 year ago

@maxim-saplin Great news! Thanks for the quick response.

DimaOstrovskyiEk commented 1 year ago

@maxim-saplin Do I need to wait a bit for the changes to appear on pub.dev?

maxim-saplin commented 1 year ago

Haven't published yet, try referencing github from pubspec directly

maxim-saplin commented 1 year ago

Pushed to pub.dev