search

maxim-saplin / data_table_2

In-place substitute for Flutter's DataTable and PaginatedDataTable with fixed/sticky header and extra features
https://pub.dev/packages/data_table_2
BSD 3-Clause "New" or "Revised" License
202 stars 135 forks source link

isHorizontalScrollBarVisible & isVerticalScrollBarVisible for AsyncPaginatedDataTable2 #257

Closed TarishAhmed closed 6 months ago

TarishAhmed commented 6 months ago

The DataTable2 have the option to show the horizontal and vertical scrollbar letting the user know there is content of the data table that is hidden from the flow and would require a scroll to view, and since AsyncPaginatedDataTable2 does not have this, this table however being much much efficient than DataTable2 for every other task, becomes harder to adopt.

GuHiroo commented 6 months ago

PaginatedDataTable2 wants the same. Have tried this but nothing about track valid.


        data: ThemeData(
            scrollbarTheme: ScrollbarThemeData(
              thumbColor: MaterialStateProperty.all(Colors.orange),
              trackColor: MaterialStateProperty.all(Colors.orange),
              trackVisibility: MaterialStateProperty.all(true),
            )),
        child: PaginatedDataTable2(...```
maxim-saplin commented 6 months ago

Any volunteers to submit a PR?

GuHiroo commented 6 months ago

The DataTable2 have the option to show the horizontal and vertical scrollbar letting the user know there is content of the data table that is hidden from the flow and would require a scroll to view, and since AsyncPaginatedDataTable2 does not have this, this table however being much much efficient than DataTable2 for every other task, becomes harder to adopt.

Hello, I've tried this and it works well for paginateddatatable2 and async one.


Theme(
        data: ThemeData(
            scrollbarTheme: ScrollbarThemeData(
              thumbVisibility: MaterialStateProperty.all(true),
            )),
        child: PaginatedDataTable2(...
TarishAhmed commented 6 months ago

@GuHiroo this works perfectly for my use case but by using this code both horizontal and vertical becomes visible

TarishAhmed commented 6 months ago

@maxim-saplin could you review this https://github.com/maxim-saplin/data_table_2/pull/261

maxim-saplin commented 6 months ago

Fixed in 2.5.11 and pushed to pub.dev. Thx to @TarishAhmed