Add option to hide heading checkbox in data table

maxim-saplin / data_table_2

In-place substitute for Flutter's DataTable and PaginatedDataTable with fixed/sticky header and extra features

https://pub.dev/packages/data_table_2

BSD 3-Clause "New" or "Revised" License

202 stars 135 forks source link

Add option to hide heading checkbox in data table #270

Closed jbournonville closed 5 months ago

jbournonville commented 5 months ago

A boolean option showHeadingCheckBox has been added to the data table configuration. This allows the user to choose whether to display the heading checkbox or not. In cases where the checkbox is not needed, a sized box takes its place instead.

maxim-saplin commented 5 months ago

Could you please added a test for this feature?

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.87%. Comparing base (2e204cf) to head (fd40709).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 95.86% 95.87% ======================================= Files 3 3 Lines 1138 1140 +2 ======================================= + Hits 1091 1093 +2 Misses 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbournonville commented 5 months ago

Could you please added a test for this feature?

Test added in cb100c4ba31cdcb568566b2769ca8e70da8b344f commit

maxim-saplin commented 5 months ago

The tricky cases of varying number of fixed cols/rows is not handled properly. Please check the /example forlder, screens/data_table2_fixed_nm.dart, try disabling the checkbox in the header and you'll see that the layout is broken:

jbournonville commented 5 months ago

The tricky cases of varying number of fixed cols/rows is not handled properly. Please check the /example forlder, screens/data_table2_fixed_nm.dart, try disabling the checkbox in the header and you'll see that the layout is broken:

fixed in 5ff65f5a2b70fbfa4b92dfcdcdce8d55d7d63b44

CleanShot 2024-03-22 at 14 10 39@2x

maxim-saplin commented 5 months ago

Looks good. Thanks for the contribution!