Icon sprites don't load--variables set to wrong path

[wolframarnold]

I think there is a bug in the bootswatch-rails code.

It overrides the variables as follows:

$iconSpritePath:          "../img/glyphicons-halflings.png";
$iconWhiteSpritePath:     "../img/glyphicons-halflings-white.png";

However, in the boostrap-sass package, these variables are set with the asset_urlhelper:

$iconSpritePath:          asset-url("glyphicons-halflings.png", image) !default;
$iconWhiteSpritePath:     asset-url("glyphicons-halflings-white.png", image) !default;

It's not even clear why that Bootswatch library needs to override these variables, because they're the same as the default.

[mathieul]

I created a simple pull request for fixing that: https://github.com/maxim/bootswatch-rails/pull/3

I just removed those variable definitions so the original ones from bootstrap-sass are taken into account. It fixed it for me.

[wolframarnold]

Thanks for doing this. I didn't have time to make a pull request, but just removing the definitions should do it, yes.

Wolf

On Thu, Apr 26, 2012 at 10:38 AM, Mathieu Lajugie < reply@reply.github.com

wrote:

I created a simple pull request for fixing that: https://github.com/maxim/bootswatch-rails/pull/3

I just removed those variable definitions so the original ones from bootstrap-sass are taken into account. It fixed it for me.

---

Reply to this email directly or view it on GitHub: https://github.com/maxim/bootswatch-rails/issues/2#issuecomment-5363289

www.RubyFocus.biz --- San Francisco --- direct: 650-576-9048

[akshayrawat]

+1.

Remove the definitions or redefine the Sprite Paths correctly.

[akshayrawat]

The commit above fixes this issue and can be closed.

[mathieul]

Thanks @maxim for bootswatch-rails!