search

maxim / bootswatch-rails

Bootswatches converted to SCSS ready to use in Rails asset pipeline.
MIT License
488 stars 84 forks source link

Fix issue #2: Icon sprites don't load--variables set to wrong path #3

Closed mathieul closed 12 years ago

maxim commented 12 years ago

Why not just add the icons and fix paths instead?

mathieul commented 12 years ago

Icons are already in bootstrap-sass gem, along with the sprite path variables. Add icons if they're different, and set icon path if the new icons need to have a different name. If not, why do anything??

alexschomb commented 12 years ago

I second that!

akshayrawat commented 12 years ago

@maxim, I think @mathieul 's approach is good. Bootswatches never provide images, just variables and css, and instead rely on the original Bootstrap's icons. Hence this gem should not deal with images either, and instead rely on bootstrap-sass for it. So icons should not be added to this project, neither should it have any image paths of its own.

+1. Please merge.

maxim commented 12 years ago

Makes sense, thanks.

akshayrawat commented 12 years ago

Can you release a new version of the gem? This patch is needed on all rails project which need icons and use bootswatch-rails

Thanks for this project boss !

dbwest commented 12 years ago

+1 to akshayrawat's request

maxim commented 12 years ago

Done, sorry for the wait guys.