Fix sprite image pathname to assets image-url function.

maxim / bootswatch-rails

Bootswatches converted to SCSS ready to use in Rails asset pipeline.

MIT License

488 stars 84 forks source link

Fix sprite image pathname to assets image-url function. #31

Closed nysalor closed 11 years ago

nysalor commented 11 years ago

$iconSpritePath and $iconWhiteSpritePath are assigned as "../img/glyphicons-halflings.png" and "../img/glyphicons-halflings-white.png", but they are not standard on Rails assets pipeline. In some applications, pict icons are not displayed because of broken pathname.

maxim commented 11 years ago

Thanks, I was thinking how to better solve this. Bootswatches actually never use glyphicons and bootstrap-sass already has these variables set via image-path, so ideally these variables shouldn't even be declared in bootswatches. In the mean time they've been marked as !default so you could easily override them.

All things considered, I think this is the best way, but I'd rather implement this via the converter script. Update is coming up.