search

maxim / bootswatch-rails

Bootswatches converted to SCSS ready to use in Rails asset pipeline.
MIT License
489 stars 84 forks source link

Update to Bootstrap 3.0 #50

Closed paul-english closed 10 years ago

paul-english commented 10 years ago

I updated my repository bootswatch-scss to match the bootswatch/bootstrap 3.0.0 changes. It was originally based off the files from this repo.

I don't know if you'll want to accept this pull-request sight unseen, as you made notes to the custom conversion scripts you've made. You may want to check out my repo to see how I generated these, there were only a handful of manual updates that needed to be made after I converted them using grunt.

This is related to issue #47

paul-english commented 10 years ago

Any update on merging this pull request?

maxim commented 10 years ago

@log0ymxm In all honesty, I'm not sure what to do about it. Will somebody constantly keep code up to date by hand? This seems unsustainable, and I myself haven't used bootswatches in a while. Would be happy to hand you commit rights if you're ok with it.

paul-english commented 10 years ago

Yeah, it's a bit of an issue to manually convert the less files, though it was simple enough this time. I'm not sure what can be done for future updates, automatic or more manual conversion.

esbanarango commented 10 years ago

1+

pcriv commented 10 years ago

+1

charlotte-miller commented 10 years ago

+1

maxim commented 10 years ago

I'm willing to give commit rights, who'd like to have them?

AndreasWurm commented 10 years ago

+1

pcriv commented 10 years ago

@log0ymxm maybe you could take the commit rights

paul-english commented 10 years ago

I'd be happy to keep the stylesheets up to date, however I don't actively use rails and wouldn't be able to follow any rails specific updates that might need to be made.

maxim commented 10 years ago

@log0ymxm @pablocrivella done, please do what you think is best

rdhanaraj commented 10 years ago

+1

kangax commented 10 years ago

+1

maxim commented 10 years ago

+1

makaroni4 commented 10 years ago

+2 :beers:

pcriv commented 10 years ago

I was finally able to integrate bootswatch in my rails app using this 2 gems in my Gemfile:

source 'https://rails-assets.org'

gem 'bootstrap-sass', '~> 3.1.1'
gem 'rails-assets-bootswatch-scss'

then in my bootstrap_and_overrides.css.scss file:

@import 'bootswatch-scss/flatly/variables';
@import 'bootstrap';
@import 'bootswatch-scss/flatly/bootswatch';
kwent commented 10 years ago

Hurry up guys ! Who is maintaining this repo now ?

ldonnet commented 10 years ago

Is there a way to migrate to bootstrap 3.0?

esbanarango commented 10 years ago

This rep (log0ymxm / bootswatch-rails) it is being maintained now. It has the last bootswatch version (3.1.1).

pcriv commented 10 years ago

@esbanarango i tried to use that repo but i get this error:

"couldn't find file '../fonts/glyphicons-halfings-regular.eot'"

esbanarango commented 10 years ago

@pablocrivella Do you have gem "bootstrap-sass" in your Gemfile?

esbanarango commented 10 years ago

@maxim I could take the commit rights on this rep and keep maintaining this.

pcriv commented 10 years ago

yes i have, @maxim gave commit rights to @log0ymxm so i think can he also give them to you @esbanarango.

paul-english commented 10 years ago

It's probably best to maintain this repo, as it's got the popularity behind it. I have commit rights, but I can't add @esbanarango.

paul-english commented 10 years ago

Btw, thanks @esbanarango, this is a repo that is hard to keep up to date.

esbanarango commented 10 years ago

Sure! I can keep maintaining this.

maxim commented 10 years ago

@esbanarango thank you, done! :+1:

pcriv commented 10 years ago

great! :clap: